linux-kernel - Re: [PATCH] drm/amdgpu/display: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 09:00:46 +0100
From:   Christian König <christian.koenig@....com>
To:     trix@...hat.com, alexander.deucher@....com, airlied@...ux.ie,
        daniel@...ll.ch, Hawking.Zhang@....com, evan.quan@....com,
        Felix.Kuehling@....com, luben.tuikov@....com, Dennis.Li@....com,
        andrey.grodzovsky@....com, Joseph.Greathouse@....com,
        jonathan.kim@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu/display: remove trailing semicolon in macro
 definition

Am 27.11.20 um 17:26 schrieb trix@...hat.com:
> From: Tom Rix <trix@...hat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index f9c81bc21ba4..301e93c9e72a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1213,7 +1213,7 @@ int emu_soc_asic_init(struct amdgpu_device *adev);
>   #define amdgpu_asic_update_umd_stable_pstate(adev, enter) \
>   	((adev)->asic_funcs->update_umd_stable_pstate ? (adev)->asic_funcs->update_umd_stable_pstate((adev), (enter)) : 0)
>   
> -#define amdgpu_inc_vram_lost(adev) atomic_inc(&((adev)->vram_lost_counter));
> +#define amdgpu_inc_vram_lost(adev) atomic_inc(&((adev)->vram_lost_counter))
>   
>   /* Common functions */
>   bool amdgpu_device_has_job_running(struct amdgpu_device *adev);