linux-kernel - Re: [PATCH] riscv/mm: Prevent kernel module access user-space memory without uaccess routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201130083015.GA14676@infradead.org>
Date:   Mon, 30 Nov 2020 08:30:15 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Eric Lin <tesheng@...estech.com>
Cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        walken@...gle.com, daniel.m.jordan@...cle.com, peterx@...hat.com,
        akpm@...ux-foundation.org, penberg@...nel.org,
        aou@...s.berkeley.edu, palmer@...belt.com,
        paul.walmsley@...ive.com, dslin1010@...il.com,
        Alan Kao <alankao@...estech.com>
Subject: Re: [PATCH] riscv/mm: Prevent kernel module access user-space memory
 without uaccess routines

> +	if (!user_mode(regs) && addr < TASK_SIZE && unlikely(!(regs->status & SR_SUM)))

Please avoid the overly long line.