linux-kernel - Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 10:17:53 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     trix@...hat.com
Cc:     njavali@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, GR-QLogic-Storage-Upstream@...vell.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition

Hi Tom,

On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Daniel Wagner <dwagner@...e.de>

> ---
>  drivers/scsi/qla2xxx/qla_def.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index ed9b10f8537d..86d249551b2d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>  } while (0)
>  
>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
> -	atomic_dec(&__qpair->ref_count);		\
> +	atomic_dec(&__qpair->ref_count)		\

Nitpick, please insert an additional tab after the remove so that the
backlashes align again.

Thanks,
Daniel