linux-kernel - Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD4AB7A-54E7-4922-9547-7E26D61F7C77@cisco.com>
Date:   Mon, 30 Nov 2020 09:15:46 +0000
From:   "Stefan Schaeckeler (sschaeck)" <sschaeck@...co.com>
To:     Troy Lee <troy_lee@...eedtech.com>,
        Rob Herring <robh+dt@...nel.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        "Borislav Petkov" <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
CC:     "leetroy@...il.com" <leetroy@...il.com>,
        "ryan_chen@...eedtech.com" <ryan_chen@...eedtech.com>,
        Stefan Schaeckeler <schaecsn@....net>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

Hello Troy,

> Adding AST2400 and AST2600 edac driver support.
>
> Signed-off-by: Troy Lee <troy_lee@...eedtech.com>
> ---
> drivers/edac/Kconfig       |   6 +-
> drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++--------
> 2 files changed, 94 insertions(+), 26 deletions(-)

Uh, there are quite some non-trivial changes. I'll have a look over the coming weekend.

Testing an edac driver comes with challenges. Did you test your code? If so, how?

That's how I was testing my original edac 2500 driver http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html

 Stefan