linux-kernel - Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201130093404.xjow7bddb5jw3myj@beryllium.lan>
Date:   Mon, 30 Nov 2020 10:34:04 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     trix@...hat.com, njavali@...vell.com, jejb@...ux.ibm.com,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        GR-QLogic-Storage-Upstream@...vell.com, linux-scsi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition

On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@...e.de> wrote:
> > >  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)             \
> > > -     atomic_dec(&__qpair->ref_count);                \
> > > +     atomic_dec(&__qpair->ref_count)         \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
> 
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.

Right! Didn't realize it. The backslash should be removed.