linux-kernel - Re: [PATCH v4 02/25] coresight: etm4x: Skip accessing TRCPDCR in save/restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 09:37:56 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, mike.leach@...aro.org,
        linux-kernel@...r.kernel.org, anshuman.khandual@....com,
        jonathan.zhouwen@...wei.com, coresight@...ts.linaro.org,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
        Tingwei Zhang <tingwei@...eaurora.org>
Subject: Re: [PATCH v4 02/25] coresight: etm4x: Skip accessing TRCPDCR in
 save/restore

On 11/27/20 6:55 PM, Mathieu Poirier wrote:
> On Thu, Nov 19, 2020 at 04:45:24PM +0000, Suzuki K Poulose wrote:
>> When the ETM is affected by Qualcomm errata, modifying the
>> TRCPDCR could cause the system hang. Even though this is
>> taken care of during enable/disable ETM, the ETM state
>> save/restore could still access the TRCPDCR. Make sure
>> we skip the access during the save/restore.
>>
>> Found by code inspection.
>>
>> Fixes: commit 02510a5aa78df45 ("coresight: etm4x: Add support to skip trace unit power up")
> 
> https://elixir.bootlin.com/linux/v5.10-rc5/source/Documentation/process/submitting-patches.rst#L121

Thanks, I will remove the "commit".

Suzuki