linux-kernel - RE: [PATCH v12 00/10] NTFS read-write driver GPL implementation by Paragon Software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cbb04e9b419a4d16b106f179df07813f@paragon-software.com>
Date:   Mon, 30 Nov 2020 09:45:27 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Aurélien Aptel <aaptel@...e.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC:     "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pali@...nel.org" <pali@...nel.org>,
        "dsterba@...e.cz" <dsterba@...e.cz>,
        "willy@...radead.org" <willy@...radead.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "joe@...ches.com" <joe@...ches.com>,
        "mark@...mstone.com" <mark@...mstone.com>,
        "nborisov@...e.com" <nborisov@...e.com>,
        "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        "anton@...era.com" <anton@...era.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "hch@....de" <hch@....de>,
        "ebiggers@...nel.org" <ebiggers@...nel.org>
Subject: RE: [PATCH v12 00/10] NTFS read-write driver GPL implementation by
 Paragon Software

From: Aurélien Aptel <aaptel@...e.com>
Sent: Tuesday, November 10, 2020 4:03 PM
> To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>; linux-fsdevel@...r.kernel.org
> Cc: viro@...iv.linux.org.uk; linux-kernel@...r.kernel.org; pali@...nel.org; dsterba@...e.cz; willy@...radead.org;
> rdunlap@...radead.org; joe@...ches.com; mark@...mstone.com; nborisov@...e.com; linux-ntfs-dev@...ts.sourceforge.net;
> anton@...era.com; dan.carpenter@...cle.com; hch@....de; ebiggers@...nel.org; Konstantin Komarov
> <almaz.alexandrovich@...agon-software.com>
> Subject: Re: [PATCH v12 00/10] NTFS read-write driver GPL implementation by Paragon Software
> 
> Hi Konstantin,
> 
> Have you looked at Eric Biggers last comments regarding KASAN and
> lockdep? You can enable KASAN in menuconfig in Kernel hacking > Memory
> debugging > KASAN.
> 
> With v12 I'm still seeing the out-of-bound read and potential deadlock.
>

Hi Aurelien! Apologies for the delayed reply. Yes, we're looking into each comment
received on the patches, and trying to take actions on each promptly. On the KASAN
and lockdep issues: it took some time to figure out how to catch and debug these :)
But now, some of the related issues are resolved. Please try out the v13.

> 
> The bad read:
> 
> [   69.496132] BUG: KASAN: stack-out-of-bounds in hdr_insert_de+0x130/0x1b0
> [   69.496137] Read of size 32 at addr ffff88800b4ffb48 by task ln/1246
> ....
> [  166.671509]  do_syscall_64+0x33/0x40
> [  166.671509]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> [  166.671509] RIP: 0033:0x7fe486a68204
> [  166.671509] Code: 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 80 00 00 00 00 8b 05 aa d1 2c 00 48 63 ff 85 c0 75 13 b8 01 00 00 00 0f 05
> <48> 3d 00 f0 ff ff 77 54 f3 c3 66 90 55 53 48 89 d5 48 89 f3 48 83
> [  166.671509] RSP: 002b:00007ffd4b76fee8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
> [  166.671509] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007fe486a68204
> [  166.671509] RDX: 0000000000000004 RSI: 000055b1dd9bb7a0 RDI: 0000000000000001
> [  166.671509] RBP: 000055b1dd9bb7a0 R08: 000000000000000a R09: 0000000000000000
> [  166.671509] R10: 000000000000000a R11: 0000000000000246 R12: 0000000000000004
> 
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

Thanks!