linux-kernel - Re: [PATCH v3] mfd: kempld-core: Check for DMI definition before ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3da927c29198afcffd16f5cb50014b1c1d8a922.camel@kontron.com>
Date:   Mon, 30 Nov 2020 13:08:36 +0000
From:   Michael Brunner <Michael.Brunner@...tron.com>
To:     "lee.jones@...aro.org" <lee.jones@...aro.org>
CC:     "linux@...ck-us.net" <linux@...ck-us.net>,
        "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
        "mibru@....de" <mibru@....de>,
        "vkrasnov@....rtsoft.ru" <vkrasnov@....rtsoft.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mvanyulin@....rtsoft.ru" <mvanyulin@....rtsoft.ru>
Subject: Re: [PATCH v3] mfd: kempld-core: Check for DMI definition before ACPI

On Fri, 2020-11-27 at 07:53 +0000, Lee Jones wrote:
> On Mon, 16 Nov 2020, Michael Brunner wrote:
> 
> > Change the detection order to priorize DMI table entries over
> > available
> > ACPI entries.
> > 
> > This makes it more easy for product developers to patch product
> > specific
> > handling into the driver.
> > Furthermore it allows to simplify the implementation a bit and
> > especially to remove the need to force synchronous probing.
> > 
> > Signed-off-by: Michael Brunner <michael.brunner@...tron.com>
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> > 
> > v3: Cleaned up comment, added Reviewed-by
> > 
> >  drivers/mfd/kempld-core.c | 24 +++---------------------
> >  1 file changed, 3 insertions(+), 21 deletions(-)
> 
> Nit: Just letting you know that checkpatch.pl complains about your
> patches, since your From: address does not match your SoB one.
> 
> Patch applied though, thanks.

Thanks!

Regarding the From - I guess it is because the upper-case letters. I
will check how to fix this for the next time. In the worst case I guess
I have to adapt the SoB.