linux-kernel - Re: [PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201130131848.GA11190@osiris>
Date:   Mon, 30 Nov 2020 14:18:48 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     kbuild-all@...ts.01.org, svens@...ux.ibm.com,
        clang-built-linux@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] include/getcpu.h: Fixed kernel test robot
 warning

On Sat, Nov 28, 2020 at 09:11:57PM +0530, Souptick Joarder wrote:
> Kernel test robot generates below warning ->
> 
> >> arch/s390/kernel/vdso64/getcpu.c:8:5: warning: no previous prototype
> >> for function '__s390_vdso_getcpu' [-Wmissing-prototypes]
>    int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
>        ^
>    arch/s390/kernel/vdso64/getcpu.c:8:1: note: declare 'static' if the
> function is not intended to be used outside of this translation unit
>    int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
>    ^
>    static
>    1 warning generated.
> 
> vim +/__s390_vdso_getcpu +8 arch/s390/kernel/vdso64/getcpu.c
> 
>      7
>    > 8  int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
>    > getcpu_cache *unused)
> 
> It is fixed by adding a prototype.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  include/linux/getcpu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/getcpu.h b/include/linux/getcpu.h
> index c304dcd..43c9208 100644
> --- a/include/linux/getcpu.h
> +++ b/include/linux/getcpu.h
> @@ -16,4 +16,5 @@ struct getcpu_cache {
>  	unsigned long blob[128 / sizeof(long)];
>  };
>  
> +int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);

Sorry, no. We won't add s390 specific prototypes to common code header
files. Anyway, I solved this differently and the "fix" should be in
linux-next soon.