linux-kernel - Re: [PATCH] arm64: dts: meson: update the Khadas VIM3/3L LED bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d481a9f0-1d9c-2989-edd3-83f7c549f228@baylibre.com>
Date:   Mon, 30 Nov 2020 14:25:25 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Christian Hewitt <christianshewitt@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...libre.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Artem Lapkin <art@...das.com>
Subject: Re: [PATCH] arm64: dts: meson: update the Khadas VIM3/3L LED bindings

On 25/11/2020 06:29, Christian Hewitt wrote:
> Update the VIM3/3L common dtsi to use the new function/color bindings.
> 
> Suggested-by: Artem Lapkin <art@...das.com>
> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> ---
> This supersedes a previous submission from Art [0] and uses the updated
> LED bindings suggested by Neil.
> 
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200925033017.1790973-4-art@khadas.com/
> 
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 87bd8c9516f2..8f8656262ae7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -6,6 +6,7 @@
>   */
>  
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
>  #include <dt-bindings/gpio/meson-g12a-gpio.h>
>  #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
>  
> @@ -42,14 +43,16 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		led-white {
> -			label = "vim3:white:sys";
> +		white {
> +			color = <LED_COLOR_ID_WHITE>;
> +			function = LED_FUNCTION_STATUS;
>  			gpios = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};
>  
> -		led-red {
> -			label = "vim3:red";
> +		red {
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_STATUS;
>  			gpios = <&gpio_expander 5 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>