linux-kernel - Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55abc980-2493-5c29-da80-4bb1446fa37d@redhat.com>
Date:   Mon, 30 Nov 2020 14:30:40 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Zou Wei <zou_wei@...wei.com>, justin.ernst@....com,
        mgross@...ux.intel.com
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static
 keyword

Hi,

+Cc x86 folks

On 11/30/20 12:11 PM, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
> drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Since this is a fix to a series merged through the x86/tip tree, this should be merged
to the x86/tip tree too (or I can pick it up after 5.11-rc1).

Here is my ack for merging this through the x86/tip tree:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/platform/x86/uv_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 54c3425..c780a4b 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -19,8 +19,8 @@
>  #define INVALID_CNODE -1
>  
>  struct kobject *sgi_uv_kobj;
> -struct kset *uv_pcibus_kset;
> -struct kset *uv_hubs_kset;
> +static struct kset *uv_pcibus_kset;
> +static struct kset *uv_hubs_kset;
>  static struct uv_bios_hub_info *hub_buf;
>  static struct uv_bios_port_info **port_buf;
>  static struct uv_hub **uv_hubs;
>