linux-kernel - Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8Rj0s/Emv9Qmv3d@jagdpanzerIV.localdomain>
Date:   Mon, 30 Nov 2020 12:15:30 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Christoph Hellwig <hch@....de>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Namjae Jeon <linkinjeon@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on
 non-posix-acl build

On (20/11/29 18:00), Randy Dunlap wrote:
> On 11/29/20 5:44 PM, Sergey Senozhatsky wrote:
> > Some functions that are declared when CONFIG_POSIX_ACL is defined
> > are not declared when CONFIG_POSIX_ACL is not defined. Add the
> > missing ones:
> >   set_posix_acl(), posix_acl_update_mode(), get_cached_acl(),
> >   get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> Hi,
> 
> I can't find CONFIG_POSIX_ACL in the kernel source tree.
> Should it be CONFIG_FS_POSIX_ACL ?

Oh, yes, CONFIG_POSIX_ACL. My bad.

> How did you test this?

You know what - scratch this patch. Sorry for the noise.

Some of the posix_acl.h functions are guarded by ifdef/ifndef
CONFIG_FS_POSIX_ACL, and some are not. This can break the build
if the code in question doesn't use ifdef CONFIG_FS_POSIX_ACL
(which happens with our code). But this patch is not enough,
apparently, we need to add ifdef CONFIG_FS_POSIX_ACL to our
code anyway, because of, for instance, posix_acl_alloc() which
is undefined for !FS_POSIX_ACL builds. Sorry for the noise.

	-ss