linux-kernel - Re: [PATCH] arm64: dts: freescale: sl28: correct MMC order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8115204301687a0576d4ddb4f799d0fa@walle.cc>
Date:   Mon, 30 Nov 2020 16:18:58 +0100
From:   Michael Walle <michael@...le.cc>
To:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Yangbo Lu <yangbo.lu@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH] arm64: dts: freescale: sl28: correct MMC order

Am 2020-11-24 22:21, schrieb Michael Walle:
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
> 
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
> 
>  	aliases {
>  		crypto = &crypto;
> +		mmc0 = &esdhc1;
> +		mmc1 = &esdhc;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &lpuart1;

This will be superfluous because Vladimirs patch was applied:
https://lore.kernel.org/linux-devicetree/20201130143923.GK4072@dragon/

Thanks!
-michael