linux-kernel - Re: [PATCH] kasan, mm: fix build issue with asmlinkage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAeHK+xn=aOq7vU0FKNDj8txU6y05g-5=mnkcn3RsWJsoPCfFg@mail.gmail.com>
Date:   Mon, 30 Nov 2020 16:21:41 +0100
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Marco Elver <elver@...gle.com>
Subject: Re: [PATCH] kasan, mm: fix build issue with asmlinkage

On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <elver@...gle.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@...edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andreyknvl@...gle.com>
> > Date:   Tue Nov 24 16:45:08 2020 +1100
> >
> >     kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes:   2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
>
> Reviewed-by: Marco Elver <elver@...gle.com>
>
> Probably want to add
>
>   Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.

Reviewed-by: Andrey Konovalov <andreyknvl@...gle.com>

Thank you, Valdis!