linux-kernel - Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd28f304-cb55-8377-c5eb-2adf3ab48f79@gmail.com>
Date:   Mon, 30 Nov 2020 16:58:17 +0100
From:   Rafał Miłecki <zajec5@...il.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Hauke Mehrtens <hauke@...ke-m.de>,
        bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

On 30.11.2020 16:43, Vinod Koul wrote:
> On 16-11-20, 08:46, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>>
>> 1. Change syntax from txt to yaml
>> 2. Drop "Driver for" from the title
>> 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check)
>> 4. Specify license
>>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
>> ---
>> I think this should go through linux-phy tree. Kishon, Vinod, can you
>> take this patch?
>>
>> This patch generates a false positive checkpatch.pl warning [0].
>> Please ignore:
>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
> 
> I am seeing warnings for indentation:
> 
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:20:12: [warning] wrong indentation: expected 12 but found 11 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:51:6: [warning] wrong indentation: expected 4 but found 5 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:71:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:80:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:88:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
> 
> Can you pls fix those as well

Sure, just note, it's a different YAML file (I missed that initially and was
triple checking my bcm-ns-usb3-phy.yaml ;) ). So I'll handle it using a
different patch.