linux-kernel - Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201130163006.fvr4rs7524fymihu@beryllium.lan>
Date:   Mon, 30 Nov 2020 17:30:06 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     Tom Rix <trix@...hat.com>
Cc:     njavali@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, GR-QLogic-Storage-Upstream@...vell.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition

> >>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
> >> -	atomic_dec(&__qpair->ref_count);		\
> >> +	atomic_dec(&__qpair->ref_count)		\
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> 
> How about removing the last escaped newline and the next empty line ?

Yes please.