lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2020 08:43:17 -0800 From: Joe Perches <joe@...ches.com> To: Dwaipayan Ray <dwaipayanray1@...il.com> Cc: linux-kernel-mentees@...ts.linuxfoundation.org, linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com, Peilin Ye <yepeilin.cs@...il.com> Subject: Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe On Mon, 2020-11-30 at 20:15 +0530, Dwaipayan Ray wrote: > checkpatch reports a false TYPO_SPELLING warning for some words > containing an apostrophe. > > A false positive is "doesn't". Occurrence of the word causes > checkpatch to emit the following warning: > > "WARNING: 'doesn'' may be misspelled - perhaps 'doesn't'?" > > Check the word boundary for such cases so that words like > "doesn't", "zig-zag", etc. aren't misinterpreted due to wrong > splitting of the word by the \b regex metacharacter. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3106,7 +3106,7 @@ sub process { > # Check for various typo / spelling mistakes > if (defined($misspellings) && > ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { > - while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) { > + while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b(?![^\w]?[a-z@]+)|$|[^a-z@])/gi) { Wouldn't it be simpler to change the existing [^a-z@] blocks to [^a-z@'-] ?
Powered by blists - more mailing lists