linux-kernel - Re: [PATCH v2 2/4] configfs: use BIT() for internal flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201201112215.GA31985@lst.de>
Date:   Tue, 1 Dec 2020 12:22:15 +0100
From:   Christoph Hellwig <hch@....de>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Joel Becker <jlbec@...lplan.org>, Christoph Hellwig <hch@....de>,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v2 2/4] configfs: use BIT() for internal flags

On Mon, Nov 30, 2020 at 05:47:02PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> For better readability and maintenance: use the BIT() macro for flag
> definitions.

This does not improve readability, as I now need to look up a macro,
one that doesn't make any sense at all.  If you really prefer bit based
numbering just use the totally obvious (1 << bit) syntax.