lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2020 16:05:24 -0800 From: Kevin Hilman <khilman@...libre.com> To: Amjad Ouled-Ameur <aouledameur@...libre.com>, Felipe Balbi <balbi@...nel.org> Cc: Philipp Zabel <p.zabel@...gutronix.de>, Jerome Brunet <jbrunet@...libre.com>, linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur <aouledameur@...libre.com> writes: > Hello Felipe and Kevin, > > > Could you please review this patchset ? The changes are OK with me. Please update based on Martin's suggestions and this can be queued up by the USB maintainers. Kevin > Thank you in advance. > > On 13/11/2020 01:05, Amjad Ouled-Ameur wrote: > >> This patchset fixes a usb suspend warning seen on the libretech-cc by >> using reset_control_rearm() call of the reset framework API. >> This call allows a reset consummer to release the reset line even when >> just triggered so that it may be triggered again by other reset >> consummers. >> >> reset_control_(de)assert() calls are called, in some meson usb drivers, >> on a shared reset line when reset_control_reset has been used. This is not >> allowed by the reset framework. >> >> Finally the meson usb drivers are updated to use this new call, which >> solves the suspend issue addressed by the previous reverted >> commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control >> use"). >> >> Important: >> Please DO NOT merge before this patch [0] is merged, it adds >> reset_control_rearm() call to the reset framework API. >> >> [0] https://lore.kernel.org/lkml/20201112230043.28987-1-aouledameur@baylib >> re.com/ >> >> Amjad Ouled-Ameur (3): >> phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use >> usb: dwc3: meson-g12a: fix shared reset control use >> phy: amlogic: meson8b-usb2: fix shared reset control use >> >> drivers/phy/amlogic/phy-meson-gxl-usb2.c | 5 ++++- >> drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ >> drivers/usb/dwc3/dwc3-meson-g12a.c | 19 +++++++++++++------ >> 3 files changed, 21 insertions(+), 7 deletions(-) >> >> > Sincerely, > Amjad
Powered by blists - more mailing lists