linux-kernel - Re: [PATCH] scsi/NCR5380: Remove in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0673d357-1b04-299b-3e53-169fddf9ae5e@gmail.com>
Date:   Wed, 2 Dec 2020 07:01:27 +1300
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Finn Thain <fthain@...egraphics.com.au>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi/NCR5380: Remove in_interrupt() test

Hi Finn,

works fine, thanks!

Tested-By: Michael Schmitz <schmitzmic@...il.com>


On 1/12/20 7:46 PM, Finn Thain wrote:
> The in_interrupt() macro is deprecated. Also, it's usage in
> NCR5380_poll_politely2() has long been redundant.
>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Cc: Ahmed S. Darwish <a.darwish@...utronix.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Link: https://lore.kernel.org/r/20201126132952.2287996-1-bigeasy@linutronix.de
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> ---
>   drivers/scsi/NCR5380.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 462d911a89f2..6972e7ceb81a 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -223,7 +223,10 @@ static int NCR5380_poll_politely2(struct NCR5380_hostdata *hostdata,
>   		cpu_relax();
>   	} while (n--);
>   
> -	if (irqs_disabled() || in_interrupt())
> +	/* Sleeping is not allowed when in atomic or interrupt contexts.
> +	 * Callers in such contexts always disable local irqs.
> +	 */
> +	if (irqs_disabled())
>   		return -ETIMEDOUT;
>   
>   	/* Repeatedly sleep for 1 ms until deadline */