linux-kernel - Re: [PATCH] gpiolib: do not print err message for EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJVM3fdcDtTggkk4d7cuPso1B5Vw-YpmTC5sYZBzY=YMmg@mail.gmail.com>
Date:   Tue, 1 Dec 2020 19:03:13 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: do not print err message for EPROBE_DEFER

On Tue, Dec 1, 2020 at 6:16 PM Grygorii Strashko
<grygorii.strashko@...com> wrote:
>
> hi Bartosz, All,
>
> On 18/11/2020 16:29, Grygorii Strashko wrote:
> > The gpiochip may have dependencies from pinmux and so got deferred. Now it
> > will print error message every time -EPROBE_DEFER is returned which is
> > unnecessary:
> >
> > "gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to register, -517"
> >
> > Hence, do suppress error message for -EPROBE_DEFER case.
> >
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> > ---
> >   drivers/gpio/gpiolib.c | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index 089ddcaa9bc6..fd2c503a6aab 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -771,9 +771,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
> >       ida_free(&gpio_ida, gdev->id);
> >   err_free_gdev:
> >       /* failures here can mean systems won't boot... */
> > -     pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
> > -            gdev->base, gdev->base + gdev->ngpio - 1,
> > -            gc->label ? : "generic", ret);
> > +     if (ret != -EPROBE_DEFER) {
> > +             pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
> > +                    gdev->base, gdev->base + gdev->ngpio - 1,
> > +                    gc->label ? : "generic", ret);
> > +     }
> >       kfree(gdev);
> >       return ret;
> >   }
> >
>
> Any comments for this patch?
>
> Note. Modern dev_err_probe() seems can't be used as gpio_chip->parent is not guaranteed to be set and
> it's not clear if chip_err() still can be used at this stage.
>
> --
> Best regards,
> grygorii

I applied this patch now. We seem to have a patch congestion on the
list - I'm trying to get through unread email but more is coming
everyday. :(

Bartosz