linux-kernel - Re: [PATCH v9 3/8] ima: Define get_ima_kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56f8a840-a61a-1ab1-bb37-419ac1338e81@linux.microsoft.com>
Date:   Tue, 1 Dec 2020 11:01:19 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>, bauerman@...ux.ibm.com,
        robh@...nel.org, gregkh@...uxfoundation.org, james.morse@....com,
        catalin.marinas@....com, sashal@...nel.org, will@...nel.org,
        mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        robh+dt@...nel.org, frowand.list@...il.com,
        vincenzo.frascino@....com, mark.rutland@....com,
        dmitry.kasatkin@...il.com, jmorris@...ei.org, serge@...lyn.com,
        pasha.tatashin@...een.com, allison@...utok.net,
        kstewart@...uxfoundation.org, takahiro.akashi@...aro.org,
        tglx@...utronix.de, masahiroy@...nel.org, bhsharma@...hat.com,
        mbrugger@...e.com, hsinyi@...omium.org, tao.li@...o.com,
        christophe.leroy@....fr
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, prsriva@...ux.microsoft.com,
        balajib@...ux.microsoft.com
Subject: Re: [PATCH v9 3/8] ima: Define get_ima_kexec_buffer() in drivers/of

On 12/1/20 3:37 AM, Mimi Zohar wrote:
> On Fri, 2020-11-13 at 11:22 -0800, Lakshmi Ramasubramanian wrote:
>> The function do_get_kexec_buffer(), defined in arch/powerpc/kexec/ima.c,
>> retrieves the address and size of the given property from the device
>> tree blob. This function does not have architecture specific code, but is
>> currently limited to powerpc. This function correctly handles a device
>> tree property that is a child node of the root node, but not anything
>> other than the immediate root child nodes.
>>
>> Define an architecture independent function, namely
>> get_ima_kexec_buffer(), in "drivers/of/ima_kexec.c". This function
>> retrieves the chosen node, namely "linux,ima-kexec-buffer", from
> 
> Please remove the word "namely", here, and throughout the patch sets.
> 
>> the device tree, and returns the address and size of the buffer used
>> for carrying forward the IMA measurement log across kexec system call.
> 
> get_ima_kexec_buffer() inlines the existing do_get_kexec_buffer() and
> get_addr_size_cells() functions, leaving a local copy of
> get_addr_size_cells().   Duplicating code isn't a good idea.
> 

I'll move get_addr_size_cells() also to drivers/of/ima_kexec.c

thanks,
  -lakshmi