linux-kernel - Re: [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76a749ac-8465-1d82-0ff5-0a46e0a29f18@linux.microsoft.com>
Date:   Tue, 1 Dec 2020 11:10:11 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>, Rob Herring <robh@...nel.org>
Cc:     bauerman@...ux.ibm.com, gregkh@...uxfoundation.org,
        james.morse@....com, catalin.marinas@....com, sashal@...nel.org,
        will@...nel.org, mpe@...erman.id.au, benh@...nel.crashing.org,
        paulus@...ba.org, frowand.list@...il.com,
        vincenzo.frascino@....com, mark.rutland@....com,
        dmitry.kasatkin@...il.com, jmorris@...ei.org, serge@...lyn.com,
        pasha.tatashin@...een.com, allison@...utok.net,
        kstewart@...uxfoundation.org, takahiro.akashi@...aro.org,
        tglx@...utronix.de, masahiroy@...nel.org, bhsharma@...hat.com,
        mbrugger@...e.com, hsinyi@...omium.org, tao.li@...o.com,
        christophe.leroy@....fr, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        prsriva@...ux.microsoft.com, balajib@...ux.microsoft.com
Subject: Re: [PATCH v9 0/8] Carry forward IMA measurement log on kexec on
 ARM64

On 12/1/20 3:34 AM, Mimi Zohar wrote:
> On Sat, 2020-11-21 at 06:38 -0800, Lakshmi Ramasubramanian wrote:
>> On 11/21/20 5:57 AM, Rob Herring wrote:
>>> On Fri, Nov 13, 2020 at 11:22:35AM -0800, Lakshmi Ramasubramanian wrote:
> 
>>>>    arch/powerpc/include/asm/kexec.h       |   1 -
>>>>    arch/powerpc/kexec/Makefile            |   7 +-
>>>>    arch/powerpc/kexec/file_load.c         |  32 --------
>>>>    arch/powerpc/kexec/ima.c               | 106 ++-----------------------
>>>>    drivers/of/Makefile                    |   9 +++
>>>
>>>>    drivers/of/ima_kexec.c                 |  91 +++++++++++++++++++++
>>>>    drivers/of/kexec_fdt.c                 |  55 +++++++++++++
>>>
>>> Does this need to be 2 files? Just kexec.c?
>>
>> Since the functions defined in "ima_kexec.c" and "kexec_fdt.c" are
>> enabled on 2 different kernel CONFIGs, keeping them in 2 files enables
>> us to avoid using "#ifdef" in C files.
> 
> Normally that is true, but just as all of the kexec related functions
> are co-located in ima/ima_kexec.c, co-locating all of the kexec related
> functions in drivers/of makes sense.
> 

Sounds good - i'll make the change.
Instead of "#ifdef" will use "IS_ENABLED" macro, and define the kexec 
related functions in drivers/of/ima_kexec.c

thanks,
  -lakshmi