linux-kernel - Re: [PATCH 3/3] firmware: xilinx: Properly align function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 01 Dec 2020 11:42:21 -0800
From:   Joe Perches <joe@...ches.com>
To:     Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jolly Shah <jolly.shah@...inx.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Tejas Patel <tejas.patel@...inx.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] firmware: xilinx: Properly align function parameter

On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote:
> Fix parameters alignment reported by checkpatch --strict.

Please use a newer checkpatch as the 80 column warning
isn't enforced quite the same way.

> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
[]
> @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type)
>  }
>  
> 
>  static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset,
> -			   const enum zynqmp_pm_reset_action assert_flag)
> +					 const enum zynqmp_pm_reset_action
> +					 assert_flag)

I think these changes aren't very good as it separates
the type from the variable name.

> @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node)
>  }
>  
> 
>  static inline int zynqmp_pm_set_requirement(const u32 node,
> -					const u32 capabilities,
> -					const u32 qos,
> -					const enum zynqmp_pm_request_ack ack)
> +					    const u32 capabilities,
> +					    const u32 qos,
> +					    const enum zynqmp_pm_request_ack
> +					    ack)