linux-kernel - Re: [PATCH 3/4] f2fs: fix wrong block count instead of bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201201040935.GC3858797@google.com>
Date:   Mon, 30 Nov 2020 20:09:35 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     linux-kernel@...r.kernel.org, kernel-team@...roid.com
Cc:     Linux F2FS Dev Mailing List 
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 3/4] f2fs: fix wrong block count instead of bytes

On 11/25, Jaegeuk Kim wrote:
> We should convert cur_lblock, a block count, to bytes for len.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/data.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index a84e5bc09337..e49c14ccfafe 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3893,7 +3893,7 @@ static int check_swap_activate_fast(struct swap_info_struct *sis,
>  	sector_t highest_pblock = 0;
>  	int nr_extents = 0;
>  	unsigned long nr_pblocks;
> -	unsigned long len;
> +	u64 len;
>  	int ret;
>  
>  	/*
> @@ -3911,7 +3911,7 @@ static int check_swap_activate_fast(struct swap_info_struct *sis,
>  		cond_resched();
>  
>  		memset(&map_bh, 0, sizeof(struct buffer_head));
> -		map_bh.b_size = len - cur_lblock;
> +		map_bh.b_size = len - blks_to_bytes(inode, cur_lblock);
>  
>  		ret = get_data_block(inode, cur_lblock, &map_bh, 0,
>  					F2FS_GET_BLOCK_FIEMAP, &next_pgofs);
> -- 
> 2.29.2.454.gaff20da3a2-goog