linux-kernel - Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160636449893.25598.14958452418456601378.b4-ty@oracle.com>
Date:   Mon, 30 Nov 2020 21:04:16 -0800 (PST)
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Michael Schmitz <schmitzmic@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Finn Thain <fthain@...egraphics.com.au>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand
 and EH

On Fri, 20 Nov 2020 15:39:56 +1100, Finn Thain wrote:

> It is possible that bus_reset_cleanup() or .eh_abort_handler could
> be invoked during NCR5380_queuecommand(). If that takes place before
> the new command is enqueued and after the ST-DMA "lock" has been
> acquired, the ST-DMA "lock" will be released again. This will result
> in a lost DMA interrupt and a command timeout. Fix this by excluding
> EH and interrupt handlers while the new command is enqueued.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: atari_scsi: Fix race condition between .queuecommand and EH
      https://git.kernel.org/mkp/scsi/c/03fe6a640a05

-- 
Martin K. Petersen	Oracle Linux Engineering