linux-kernel - Re: [PATCH] INPUT: xpad: support Ardwiino Controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201201071735.GU2034289@dtor-ws>
Date:   Mon, 30 Nov 2020 23:17:35 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     sanjay.govind9@...il.com
Cc:     aicommander@...il.com, priv.luk@...il.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] INPUT: xpad: support Ardwiino Controllers

Hi Sanjay,

On Tue, Dec 01, 2020 at 07:48:45PM +1300, sanjay.govind9@...il.com wrote:
> From: Sanjay Govind <sanjay.govind9@...il.com>
> 
> This commit adds support for Ardwiino Controllers

Thank you for resending the patch, it now is formatted properly. However
I believe you need to also add information about Ardwiino controllers to
xpad_device table so that they are properly identified by the kernel.

Thanks.

> 
> Signed-off-by: Sanjay Govind <sanjay.govind9@...il.com>
> ---
>  drivers/input/joystick/xpad.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..c9d78e2acb38 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -418,6 +418,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOXONE_VENDOR(0x0f0d),		/* Hori Controllers */
>  	XPAD_XBOX360_VENDOR(0x1038),		/* SteelSeries Controllers */
>  	XPAD_XBOX360_VENDOR(0x11c9),		/* Nacon GC100XF */
> +	XPAD_XBOX360_VENDOR(0x1209),		/* Ardwiino Controllers */
>  	XPAD_XBOX360_VENDOR(0x12ab),		/* X-Box 360 dance pads */
>  	XPAD_XBOX360_VENDOR(0x1430),		/* RedOctane X-Box 360 controllers */
>  	XPAD_XBOX360_VENDOR(0x146b),		/* BigBen Interactive Controllers */
> -- 
> 2.29.2
> 

-- 
Dmitry