lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Dec 2020 15:33:14 +0800 From: David Gow <davidgow@...gle.com> To: Daniel Latypov <dlatypov@...gle.com> Cc: Brendan Higgins <brendanhiggins@...gle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH 3/5] kunit: tool: stop using bare asserts in unit test On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov <dlatypov@...gle.com> wrote: > > Use self.assertEqual/assertNotEqual() instead. > Besides being more appropriate in a unit test, it'll also give a better > error message by show the unexpected values. > > Also > * Delete redundant check of exception types. self.assertRaises does this. > * s/kall/call. There's no reason to name it this way. > * This is probably a misunderstanding from the docs which uses it > since `mock.call` is in scope as `call`. > > Signed-off-by: Daniel Latypov <dlatypov@...gle.com> > --- This works for me, and seems pretty sensible from my rudimentary python knowledge. Reviewed-by: David Gow <davidgow@...gle.com> Cheers, -- David
Powered by blists - more mailing lists