linux-kernel - Re: [PATCH v5] drm/bridge: add it6505 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201201095930.GA1981628@ravnborg.org>
Date:   Tue, 1 Dec 2020 10:59:30 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     allen <allen.chen@....com.tw>
Cc:     Kenneth Hung <Kenneth.Hung@....com.tw>,
        Jitao Shi <jitao.shi@...iatek.com>,
        Jau-Chih Tseng <Jau-Chih.Tseng@....com.tw>,
        Yilun Lin <yllin@...gle.com>, David Airlie <airlied@...ux.ie>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Hermes Wu <hermes.wu@....com.tw>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        Jonas Karlman <jonas@...boo.se>
Subject: Re: [PATCH v5] drm/bridge: add it6505 driver

Hi Allen.
On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
> 
> From: Allen Chen <allen.chen@....com.tw>
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> Signed-off-by: Pi-Hsun Shih <pihsun@...omium.org>
> Signed-off-by: Yilun Lin <yllin@...gle.com>
> Signed-off-by: Hermes Wu <hermes.wu@....com.tw>
> Signed-off-by: Allen Chen <allen.chen@....com.tw>

I recall I provided the same comment as last time, but may remember
wrong.

New bridge drivers shall support that connector creation is optional.
This driver does not do that - see following code snippet:

+       if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
+               DRM_ERROR("Fix bridge driver to make connector optional!");
+               return -EINVAL;
+       }
+

I did not check, but likely the drive needs to implment some of the
connector hooks too. (detect, get_edid, etc).

Please include a changelog too - it can be very hard to remember what
feedback was provided when one reviews several patches/week.

	Sam