linux-kernel - Re: [RFC PATCH 1/2] block: add simple copy support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <942255077c7caf5a2b1983570e30c3bf06410f62.camel@mail.ru>
Date:   Tue, 01 Dec 2020 13:28:38 +0300
From:   Aleksei Marov <alekseymmm@...l.ru>
To:     SelvaKumar S <selvakuma.s1@...sung.com>,
        linux-nvme@...ts.infradead.org
Cc:     kbusch@...nel.org, axboe@...nel.dk, damien.lemoal@....com,
        hch@....de, sagi@...mberg.me, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, selvajove@...il.com,
        nj.shetty@...sung.com, joshi.k@...sung.com, javier.gonz@...sung.com
Subject: Re: [RFC PATCH 1/2] block: add simple copy support

On Tue, 2020-12-01 at 11:09 +0530, SelvaKumar S wrote:
> +	ret = __blkdev_issue_copy(bdev, dest, nr_srcs, rlist, gfp_mask, flags,
> +			&bio);
> +	if (!ret && bio) {
> +		ret = submit_bio_wait(bio);
> +		if (ret == -EOPNOTSUPP)
> +			ret = 0;
> +
> +		kfree(page_address(bio_first_bvec_all(bio)->bv_page) +
> +				bio_first_bvec_all(bio)->bv_offset);
> +		bio_put(bio);
> +	}
> +
> +	return ret;
> +}
I think  there is an issue here that if bio_add_page  returns error in
__blkdev_issue_copy then ret is -ENOMEM and we never do bio_put for bio
allocated in  __blkdev_issue_copy so it is small memory leak.