linux-kernel - Re: [PATCH] PCI: tegra: Read "dbi" base address to program in application logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160681913010.4714.1633762754404351653.b4-ty@arm.com>
Date:   Tue,  1 Dec 2020 10:39:21 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Vidya Sagar <vidyas@...dia.com>, robh@...nel.org,
        thierry.reding@...il.com, kw@...ux.com, jingoohan1@...il.com,
        gregkh@...uxfoundation.org, jonathanh@...dia.com,
        bhelgaas@...gle.com, amanharitsh123@...il.com
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>, sagar.tv@...il.com,
        kthota@...dia.com, linux-pci@...r.kernel.org,
        linux-tegra@...r.kernel.org, mmaddireddy@...dia.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: tegra: Read "dbi" base address to program in application logic

On Thu, 26 Nov 2020 00:55:54 +0530, Vidya Sagar wrote:
> PCIe controller in Tegra194 requires the "dbi" region base address to be
> programmed in one of the application logic registers to enable CPU access
> to the "dbi" region. But, commit a0fd361db8e5 ("PCI: dwc: Move "dbi",
> "dbi2", and "addr_space" resource setup into common code") moved the code
> that reads the whereabouts of "dbi" region to the common code causing the
> existing code in pcie-tegra194.c file to program NULL in the application
> logic registers. This is causing null pointer dereference when the "dbi"
> registers are accessed. This issue is fixed by explicitly reading the
> "dbi" base address from DT node.

Applied to pci/dwc, thanks!

[1/1] PCI: tegra: Read "dbi" base address to program in application logic
      https://git.kernel.org/lpieralisi/pci/c/d5353c00cf

Thanks,
Lorenzo