linux-kernel - Re: [PATCH] keys: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201202164555.GB91162@kernel.org>
Date:   Wed, 2 Dec 2020 18:45:55 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     trix@...hat.com, dhowells@...hat.com, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] keys: remove trailing semicolon in macro definition

On Sat, Nov 28, 2020 at 09:30:44PM -0800, Joe Perches wrote:
> On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> > On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@...hat.com wrote:
> > > From: Tom Rix <trix@...hat.com>
> > > 
> > > The macro use will already have a semicolon.
> > > 
> > > Signed-off-by: Tom Rix <trix@...hat.com>
> > 
> > I'm in-between whether this is worth of merging. The commit message
> > does not help with that decision too much.
> 
> It seems worthy of merging to me modulo whatver improvement is desired in
> the commit message.
> 
> There are 3 existing uses of request_key_net.  All have a trailing semicolon.
> There is 1 existing use of request_key_net_rcu.  It has a trailing semicolon.
> 
> No object change should occur.

OK, makes sense.

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

/Jarkko