linux-kernel - Re: [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54ca2ae1-a7c5-f587-c1e7-583b5e3113af@arm.com>
Date:   Wed, 2 Dec 2020 17:09:38 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rjw@...ysocki.net, ulf.hansson@...aro.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Lina Iyer <ilina@...eaurora.org>,
        Ram Chandrasekar <rkumbako@...eaurora.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        Anup Patel <anup.patel@....com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Zqiang <qiang.zhang@...driver.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        Mike Leach <mike.leach@...aro.org>,
        Atish Patra <atish.patra@....com>,
        Andrew Jones <drjones@...hat.com>
Subject: Re: [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based
 support



On 12/1/20 7:28 PM, Daniel Lezcano wrote:
> With the powercap dtpm controller, we are able to plug devices with
> power limitation features in the tree.
> 
> The following patch introduces the CPU power limitation based on the
> energy model and the performance states.
> 
> The power limitation is done at the performance domain level. If some
> CPUs are unplugged, the corresponding power will be subtracted from
> the performance domain total power.
> 
> It is up to the platform to initialize the dtpm tree and add the CPU.
> 
> Here is an example to create a simple tree with one root node called
> "pkg" and the CPU's performance domains.
> 
> static int dtpm_register_pkg(struct dtpm_descr *descr)
> {
> 	struct dtpm *pkg;
> 	int ret;
> 
> 	pkg = dtpm_alloc(NULL);
> 	if (!pkg)
> 		return -ENOMEM;
> 
> 	ret = dtpm_register(descr->name, pkg, descr->parent);
> 	if (ret)
> 		return ret;
> 
> 	return dtpm_register_cpu(pkg);
> }
> 
> static struct dtpm_descr descr = {
> 	.name = "pkg",
> 	.init = dtpm_register_pkg,
> };
> DTPM_DECLARE(descr);
> 
> Cc: Thara Gopinath <thara.gopinath@...aro.org>
> Cc: Lina Iyer <ilina@...eaurora.org>
> Cc: Ram Chandrasekar <rkumbako@...eaurora.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>


LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@....com>
Tested-by: Lukasz Luba <lukasz.luba@....com>

Regards,
Lukasz