linux-kernel - Re: [PATCH] menuconfig,mconf-cfg: Allow specification of ncurses location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <be7e141b-4c20-c31b-9b74-6a1369569565@broadcom.com>
Date:   Tue, 1 Dec 2020 16:42:30 -0800
From:   Scott Branden <scott.branden@...adcom.com>
To:     Bruce Ashfield <bruce.ashfield@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Broadcom Kernel Feedback List 
        <bcm-kernel-feedback-list@...adcom.com>,
        OE-core <openembedded-core@...ts.openembedded.org>,
        openembeded-devel <openembedded-devel@...ts.openembedded.org>,
        Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH] menuconfig,mconf-cfg: Allow specification of ncurses
 location

Hi Bruce,

On 2020-12-01 11:01 a.m., Bruce Ashfield wrote:
> On Tue, Dec 1, 2020 at 12:19 PM Scott Branden
> <scott.branden@...adcom.com> wrote:
>> Hi Masahiro,
>>
>> On 2020-12-01 4:25 a.m., Masahiro Yamada wrote:
>>> On Sat, Nov 28, 2020 at 9:45 AM Scott Branden
>>> <scott.branden@...adcom.com> wrote:
>>>> From: Bruce Ashfield <bruce.ashfield@...driver.com>
>>>>
>>>> In some cross build environments such as the Yocto Project build
>>>> environment it provides an ncurses library that is compiled
>>>> differently than the host's version.  This causes display corruption
>>>> problems when the host's curses includes are used instead of the
>>>> includes from the provided compiler are overridden.  There is a second
>>>> case where there is no curses libraries at all on the host system and
>>>> menuconfig will just fail entirely.
>>>>
>>>> The solution is simply to allow an override variable in
>>>> check-lxdialog.sh for environments such as the Yocto Project.  Adding
>>>> a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing
>>>> compiling and linking against the right headers and libraries.
>>>>
>>>> Signed-off-by: Jason Wessel <jason.wessel@...driver.com>
>>>> cc: Michal Marek <mmarek@...e.cz>
>>>> cc: linux-kbuild@...r.kernel.org
>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@...driver.com>
>>>> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
>>>> ---
>>> Some people solve the cross-compiling in Yocto
>>> by using pkg-config.
>>>
>>>
>>> For example,
>>>
>>> commit 067c650c456e758f933aaf87a202f841d34be269
>>> Author: Pavel Modilaynen <pavel.modilaynen@...s.com>
>>> Date:   Fri Jul 12 13:52:19 2019 +0200
>>>
>>>     dtc: Use pkg-config to locate libyaml
>>>
>>>     Using Makefile's wildcard with absolute path to detect
>>>     the presence of libyaml results in false-positive
>>>     detection when cross-compiling e.g. in yocto environment.
>>>
>>>
>>>
>>> mconf-cfg.sh already allows the path flexibility with pkg-config.
>>> Why do you want yet another hook?
>> I hope the yocto community can provide more details on this patch.
>> The yocto environment isolates the build environment from the host tools.
>> Running menuconfig with the upstream kernel does not work on the latest yocto without this patch.
> Sorry for not commenting on the origin patch, gmail buried it within
> some other threads, but luckily this one popped up.
>
> It is true that we've been carrying this for several years to deal with
> the fact that the native sysroot is not searched by the pkg-config
> called by mconf-cfg.sh (since it is separate from host and target
> pkg-config).
>
> As it turns out, in the past few weeks, we have come up with a way
> to inject those native sysroot components into pkg-config without
> the need for any changes to the scripts.
>
> Scott: if you try again the the latest oe-core, and are still seeing
> the problem with the mainline kernel, ping me, and we can see if
> the pkg-config fix isn't holding for you, at that point, yes, we may
> still need a hook like this to solve the problem.
Try reverting this kernel patch from linux-yocto and menuconfig will fail.

menuconfig actually did work with the upstream kernel until the yocto change below was introduced:
"cml1.bbclass: Handle ncurses-native being available via pkg-config"
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e

> Cheers,
>
> Bruce
>
>
>
>>>>  scripts/kconfig/mconf-cfg.sh | 8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>>  mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
>>>>
>>>> diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
>>>> old mode 100755
>>>> new mode 100644
>>>> index aa68ec95620d..32448bc198a5
>>>> --- a/scripts/kconfig/mconf-cfg.sh
>>>> +++ b/scripts/kconfig/mconf-cfg.sh
>>>> @@ -4,6 +4,14 @@
>>>>  PKG="ncursesw"
>>>>  PKG2="ncurses"
>>>>
>>>> +if [ "$CROSS_CURSES_LIB" != "" ]; then
>>>> +    echo libs=\'$CROSS_CURSES_LIB\'
>>>> +    if [ x"$CROSS_CURSES_INC" != x ]; then
>>>> +       echo cflags=\'$CROSS_CURSES_INC\'
>>>> +    fi
>>>> +    exit 0
>>>> +fi
>>>> +
>>>>  if [ -n "$(command -v pkg-config)" ]; then
>>>>         if pkg-config --exists $PKG; then
>>>>                 echo cflags=\"$(pkg-config --cflags $PKG)\"
>>>> --
>>>> 2.17.1
>>>>
>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4169 bytes)