linux-kernel - Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Dec 2020 13:27:00 -0600
From:   Mike Christie <michael.christie@...cle.com>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        Nilesh Javali <njavali@...vell.com>,
        Manish Rangankar <mrangankar@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in
 __qedi_probe

On 11/9/20 3:15 AM, Qinglang Miao wrote:
> Add the missing destroy_workqueue() before return from
> __qedi_probe in the error handling case when fails to
> create workqueue qedi->offload_thread.
> 
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 61fab01d2d52..f5fc7f518f8a 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -2766,7 +2766,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
>  			QEDI_ERR(&qedi->dbg_ctx,
>  				 "Unable to start offload thread!\n");
>  			rc = -ENODEV;
> -			goto free_cid_que;
> +			goto free_tmf_thread;
>  		}
>  
>  		INIT_DELAYED_WORK(&qedi->recovery_work, qedi_recovery_handler);
> @@ -2790,6 +2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
>  
>  	return 0;
>  
> +free_tmf_thread:
> +	destroy_workqueue(qedi->tmf_thread);
>  free_cid_que:
>  	qedi_release_cid_que(qedi);
>  free_uio:
> 

Reviewed-by: Mike Christie <michael.christie@...cle.com>