linux-kernel - Re: [PATCH v2] iio: sx9310: Fix semtech,avg-pos-strength setting when

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160693757954.2717324.3993650083941744982@swboyd.mtv.corp.google.com>
Date:   Wed, 02 Dec 2020 11:32:59 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Daniel Campello <campello@...omium.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Douglas Anderson <dianders@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Evan Green <evgreen@...omium.org>
Subject: Re: [PATCH v2] iio: sx9310: Fix semtech,avg-pos-strength setting when > 16

Quoting Jonathan Cameron (2020-11-21 07:02:45)
> On Sat, 21 Nov 2020 14:58:49 +0000
> Jonathan Cameron <jic23@...nel.org> wrote:
> 
> > On Fri, 20 Nov 2020 10:29:44 -0800
> > Stephen Boyd <swboyd@...omium.org> wrote:
> > > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
> > > index a2f820997afc..ee1b4ff05a37 100644
> > > --- a/drivers/iio/proximity/sx9310.c
> > > +++ b/drivers/iio/proximity/sx9310.c
> > > @@ -1305,7 +1305,7 @@ sx9310_get_default_reg(struct sx9310_data *data, int i,
> > >             if (ret)
> > >                     break;
> > >  
> > > -           pos = min(max(ilog2(pos), 3), 10) - 3;
> > > +           pos = min(max(ilog2(pos), 3), 11) - (pos >= 32 ? 4 : 3);  
> > 
> > Given this is now rather tricky to read, I'd just do an explicit lookup of
> > the allowed values.  Probably just a switch statement.
> As an alternative, a comment would help saying that it's powers of 2 except
> for a gap at 64.
> 

Ok. I'll update with a comment.