linux-kernel - Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com>
Date:   03 Dec 2020 07:57:04 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     mdurnev@...il.com
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        mikhail_durnev@...tor.com
Subject: Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params


Hi Mikhail

Thank you for your patch

> +			switch (rsnd_mod_id(src_mod)) {
> +			/*
> +			 * SRC0 can downsample 4, 6 and 8 channel audio up to 4 times.
> +			 * SRC1, SRC3 and SRC4 can downsample 4 channel audio
> +			 * up to 4 times.
> +			 * SRC1, SRC3 and SRC4 can downsample 6 and 8 channel audio
> +			 * no more than twice.
> +			 */
> +			case 1:
> +			case 3:
> +			case 4:
> +				if (channel > 4) {
> +					k_down = 2;
> +					break;
> +				}
> +			case 0:
> +				if (channel > 2)
> +					k_down = 4;
> +				break;
> +
> +			/* Other SRC units do not support more than 2 channels */
> +			default:
> +				if (channel > 2)
> +					return -EINVAL;
> +			}

I think you want to add "fallthrough" between case 1/3/4 and case 0 ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto