linux-kernel - [PATCH v2 3/4] mmc: rtsx: fix sdmmc_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201202063618.18402-1-ricky_wu@realtek.com>
Date:   Wed, 2 Dec 2020 14:36:18 +0800
From:   <ricky_wu@...ltek.com>
To:     <arnd@...db.de>, <gregkh@...uxfoundation.org>,
        <bhelgaas@...gle.com>, <ricky_wu@...ltek.com>,
        <vaibhavgupta40@...il.com>, <kdlnx@...h.eu>,
        <ulf.hansson@...aro.org>, <linus.walleij@...aro.org>,
        <lee.jones@...aro.org>, <dianders@...omium.org>,
        <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH v2 3/4] mmc: rtsx: fix sdmmc_switch_voltage return bug

From: Ricky Wu <ricky_wu@...ltek.com>

fixed bug:
return err always return rtsx_pci_write_register() return code
not for callback function _switch_voltage()

Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
---
 drivers/mmc/host/rtsx_pci_sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index eb395e144207..93be9fa97098 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -1249,7 +1249,7 @@ static int sdmmc_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios)
 
 out:
 	/* Stop toggle SD clock in idle */
-	err = rtsx_pci_write_register(pcr, SD_BUS_STAT,
+	rtsx_pci_write_register(pcr, SD_BUS_STAT,
 			SD_CLK_TOGGLE_EN | SD_CLK_FORCE_STOP, 0);
 
 	mutex_unlock(&pcr->pcr_mutex);
-- 
2.17.1