linux-kernel - Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9dbf2dd5-40db-3cbf-4d53-b027435ccbfe@xilinx.com>
Date:   Wed, 2 Dec 2020 08:31:13 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Michal Simek <michal.simek@...inx.com>
CC:     Zou Wei <zou_wei@...wei.com>, <rajan.vaja@...inx.com>,
        <jolly.shah@...inx.com>, <tejas.patel@...inx.com>,
        <manish.narani@...inx.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with
 static keyword



On 01. 12. 20 22:26, Greg KH wrote:
> On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
>>
>>
>> On 01. 12. 20 12:51, Zou Wei wrote:
>>> Fix the following sparse warning:
>>>
>>> drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
>>>
>>> Signed-off-by: Zou Wei <zou_wei@...wei.com>
>>> ---
>>>  drivers/firmware/xilinx/zynqmp.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>>> index d08ac82..fd95ede 100644
>>> --- a/drivers/firmware/xilinx/zynqmp.c
>>> +++ b/drivers/firmware/xilinx/zynqmp.c
>>> @@ -29,7 +29,7 @@
>>>  #define PM_API_FEATURE_CHECK_MAX_ORDER  7
>>>  
>>>  static bool feature_check_enabled;
>>> -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>> +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>>  
>>>  /**
>>>   * struct pm_api_feature_data - PM API Feature data
>>>
>>
>> The patch is good but I am missing fixed tag to get it to LTS.
> 
> Why is this needed for any stable kernel release?  It's a sparse
> warning, no one trips across those in stable kernels...

Ok thanks for explanation.

Applied to zynqmp/soc branch.

Thanks,
Michal