linux-kernel - Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201202081407.GA7157@kozik-lap>
Date:   Wed, 2 Dec 2020 10:14:07 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     robh@...nel.org, shawnguo@...nel.org, festevam@...il.com,
        catalin.marinas@....com, will@...nel.org, georgi.djakov@...aro.org,
        cdleonard@...il.com, kernel@...gutronix.de, linux-imx@....com,
        kernel@...i.sm, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, Leonard Crestez <leonard.crestez@....com>
Subject: Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes

On Tue, Dec 01, 2020 at 01:39:26PM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@....com>
> 
> Add initial support for dynamic frequency scaling of main NOC.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>
> Tested-by: Martin Kepplinger <martin.kepplinger@...i.sm> (imx8mq)
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>  3 files changed, 66 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c824f2615fe8..835b19f0ea42 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -921,6 +921,28 @@
>  
>  		};
>  
> +		noc: interconnect@...00000 {
> +			compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MM_CLK_NOC>;
> +			devfreq = <&ddrc>;

This does not pass the dtschema checks. Are you missing here any
dependencies?

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: interconnect@...00000: 'devfreq' does not match any of the regexes: 'pinctrl-[0-9]+'

Best regards,
Krzysztof