linux-kernel - Re: [PATCH] gconfig: avoid use of hard coded colors for rows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67b44d49-d23c-fab0-e165-cc84817562af@infradead.org>
Date:   Tue, 1 Dec 2020 17:02:17 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ebrahim Byagowi <ebrahim@....org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gconfig: avoid use of hard coded colors for rows

On 11/23/20 1:51 PM, Ebrahim Byagowi wrote:
> Not an important thing of course just that I was unable to
> use gconfig on my system with a theme dark is set like [1]
> and this turns it into [2] without noticable change to the
> light theme.
> 
> I had hit this minor issue also in the past but decided to
> fix it this time.
> 
> This isn't the best possible approach as now we have we have
> a GdkColor -> gchar * -> GdkColor round trip, yet wanted to
> keep the change small and maybe go for a larger change later
> if it worths it.
> 
> Hope you find it useful also.
> 
>   [1]: https://i.imgur.com/MJfIkup.png
>   [2]: https://i.imgur.com/lgvod9V.png

Hi,

AFAIK, this makes one known gconfig user.
I was hoping that we could remove it...


-- 
~Randy