linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Dec 2020 19:06:45 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi_dma0 node

On Mon 30 Nov 22:25 CST 2020, Vinod Koul wrote:

> gpi_dma0 can be used for spi and i2c transfers on db845c, so enable it
> 
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 7cc236575ee2..0653468f26ce 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -418,6 +418,10 @@ &gcc {
>  			   <GCC_QSPI_CNOC_PERIPH_AHB_CLK>;
>  };
>  
> +&gpi_dma0 {
> +	status = "okay";
> +};
> +

But you're only enabling the gpi, you don't have anything wired to it,
so why enable it?

I took a look downstream and they have all the i2c and spi nodes with
their dmas filled out - and the two gpis enabled at all times
(sdm845.dtsi). Can/should we do the same?

Regards,
Bjorn

>  &gpu {
>  	zap-shader {
>  		memory-region = <&gpu_mem>;
> -- 
> 2.26.2
>