linux-kernel - Re: [PATCH v3 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201202115504.w52yeixpg7nbzw2v@liuwe-devbox-debian-v2>
Date:   Wed, 2 Dec 2020 11:55:04 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Michael Kelley <mikelley@...rosoft.com>,
        Matheus Castello <matheus@...tello.eng.br>, wei.liu@...nel.org,
        joe@...ches.com, KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>, sashal@...nel.org,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

On Sun, Nov 29, 2020 at 09:43:28PM -0800, Stephen Hemminger wrote:
> On Sun, 29 Nov 2020 08:51:47 -0800
> "Michael Kelley" <mikelley@...rosoft.com> wrote:
> 
> > From: Matheus Castello <matheus@...tello.eng.br> Sent: Tuesday, November
> > 24, 2020 7:29 PM
> > > 
> > > Checkpatch emits WARNING: quoted string split across lines.
> > > To keep the code clean and with the 80 column length indentation the
> > > check and registration code for kmsg_dump_register has been transferred
> > > to a new function hv_kmsg_dump_register.
> > > 
> > > Signed-off-by: Matheus Castello <matheus@...tello.eng.br>
> > > ---
> > > This is the V3 of patch 4 of the series "Add improvements suggested by
> > > checkpatch for vmbus_drv" with the changes suggested by Michael Kelley  
> > and
> > > Joe Perches. Thanks!
> > > ---
> > >  drivers/hv/vmbus_drv.c | 35 ++++++++++++++++++++---------------
> > >  1 file changed, 20 insertions(+), 15 deletions(-)
> > > 
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > > index 61d28c743263..edcc419ba328 100644
> > > --- a/drivers/hv/vmbus_drv.c
> > > +++ b/drivers/hv/vmbus_drv.c
> > > @@ -1387,6 +1387,24 @@ static struct kmsg_dumper hv_kmsg_dumper = {
> > >  	.dump = hv_kmsg_dump,
> > >  };
> > > 
> > > +static void hv_kmsg_dump_register(void)
> > > +{
> > > +	int ret;
> > > +
> > > +	hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
> 
> I know you just copy/pasted the original code, but one other thing.
> 
> Doesn't it already return void *?
> arch/x86/include/asm/mshyperv.h:void *hv_alloc_hyperv_zeroed_page(void);

Good catch.

I have amended this patch and applied it to hyperv-next.

Wei.