[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <X8eblRy3iqjcInyg@aptenodytes>
Date: Wed, 2 Dec 2020 14:50:13 +0100
From: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image
sensor
Hi Sakari,
On Mon 30 Nov 20, 15:53, Sakari Ailus wrote:
> Hi Paul,
>
> On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote:
> > Hi Sakari,
> >
> > On Mon 30 Nov 20, 11:28, Sakari Ailus wrote:
> > > Hi Paul,
> > >
> > > Thanks for the update. I have a few comments on the driver, too.
> >
> > Thanks for the review!
> >
> > [...]
> >
> > > > + ret = ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG,
> > > > + OV5648_GAIN_BLUE_MAN_L(blue_balance));
> > >
> > > return ...
> > >
> > > Same below (and above).
> >
> > Well I don't think that makes any functional difference, right?
> > My personal preference is to have explicit checks even at the end of functions
> > for symetry and alignment with other blocks.
> >
> > If it's okay, it'd like to keep it as-is. But if that's against kernel coding
> > style guidelines, I won't argue more.
>
> Please do change them.
>
> It's useless code, repeated at the end of a number of functions in this
> driver. I wouldn't mind otherwise, but people do take examples from
> existing drivers so such patterns tend to repeat in other places.
I don't agree that it's useless but I will do as you ask.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists