linux-kernel - Re: [PATCH v2 3/4] dma-buf: add export symbol for dma-heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201202135103.GA5902@infradead.org>
Date:   Wed, 2 Dec 2020 13:51:03 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, hyesoo.yu@...sung.com,
        willy@...radead.org, david@...hat.com, iamjoonsoo.kim@....com,
        vbabka@...e.cz, surenb@...gle.com, pullip.cho@...sung.com,
        joaodias@...gle.com, hridya@...gle.com, sumit.semwal@...aro.org,
        john.stultz@...aro.org, Brian.Starkey@....com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        robh@...nel.org, christian.koenig@....com,
        linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH v2 3/4] dma-buf: add export symbol for dma-heap

On Tue, Dec 01, 2020 at 09:51:43AM -0800, Minchan Kim wrote:
> From: Hyesoo Yu <hyesoo.yu@...sung.com>
> 
> The heaps could be added as module, so some functions should
> be exported to register dma-heaps. And dma-heap of module can use
> cma area to allocate and free. However the function related cma
> is not exported now. Let's export them for next patches.
> 
> Signed-off-by: Hyesoo Yu <hyesoo.yu@...sung.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

NAK.  I really don't think any module has business gaining that
kind of low-level access to the various symbols.  I think in general
your heap can just be built-in and we should be fine.