linux-kernel - Re: [PATCH v2 0/2] openat2: reject RESOLVE_BENEATH|RESOLVE_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201202144342.dzks7olzr4owv3ev@wittgenstein>
Date:   Wed, 2 Dec 2020 15:43:42 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Aleksa Sarai <cyphar@...har.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Shuah Khan <shuah@...nel.org>,
        containers@...ts.linux-foundation.org,
        linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

On Wed, Oct 28, 2020 at 10:50:42AM +1100, Aleksa Sarai wrote:
> This was an oversight in the original implementation, as it makes no
> sense to specify both scoping flags to the same openat2(2) invocation
> (before this patch, the result of such an invocation was equivalent to
> RESOLVE_IN_ROOT being ignored).
> 
> This is a userspace-visible ABI change, but the only user of openat2(2)
> at the moment is LXC which doesn't specify both flags and so no
> userspace programs will break as a result.
> 
> Changelog:
>   v2: Split patch so as to separate selftest changes. [Shuah Khan]
>   v1: <https://lore.kernel.org/lkml/20201007103608.17349-1-cyphar@cyphar.com/>
> 
> Aleksa Sarai (2):
>   openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
>   selftests: openat2: add RESOLVE_ conflict test
> 
>  fs/open.c                                      | 4 ++++
>  tools/testing/selftests/openat2/openat2_test.c | 8 +++++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)

I've applied this patchset now. There's no need to have this sit around
another merge window. I'm happy to drop it again in case you're picking
it up later, Al.

Thanks!
Christian