linux-kernel - Re: linux-next: Fixes tag needs some work in the mailbox tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201201214315.523923a0@oasis.local.home>
Date:   Tue, 1 Dec 2020 21:43:15 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Jassi Brar <jaswinder.singh@...aro.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the mailbox tree

On Wed, 2 Dec 2020 12:39:39 +1100
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   983df5f2699f ("samples/ftrace: Mark my_tramp[12]? global")
> 
> Fixes tag
> 
>   Fixes: 9d907f1ae80b8 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
> 
> Maybe you meant
> 
> Fixes: 9d907f1ae80b ("samples/ftrace: Fix asm function ELF annotations")
> 
> or
> 
> Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
> 

Bah! Too late, it already made it into Linus's tree.

I goofed. I was looking at both commits to see which one to apply it
for, and ended up mixing the two.

It was meant for:

Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")

I'll have to add a script to my tests that makes sure the Fixes tag
matches the description.

-- Steve