linux-kernel - Re: [PATCH] Fix UV4 Hub Revision adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201203155911.GQ1798712@swahl-home.5wahls.com>
Date:   Thu, 3 Dec 2020 09:59:11 -0600
From:   Steve Wahl <steve.wahl@....com>
To:     Mike Travis <mike.travis@....com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Hans de Goede <hdegoede@...hat.com>,
        Steve Wahl <steve.wahl@....com>, x86@...nel.org,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix UV4 Hub Revision adjustment

Reviewed-by: Steve Wahl <steve.wahl@....com>

On Thu, Dec 03, 2020 at 09:22:52AM -0600, Mike Travis wrote:
> Fix UV4 Hub Revision adjustment as Hub chip starts with revision 1.
> Incorrectly identifies UV4 as UV4A and UV4A as UV5.
> 
> Fixes 647128f1536ef: x86/platform/uv: Update UV MMRs for UV5
> 
> Signed-off-by: Mike Travis <mike.travis@....com>
> Acked-by: Dimitri Sivanich <dimitri.sivanich@....com>
> ---
>  arch/x86/kernel/apic/x2apic_uv_x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c
> index 1b98f8c12b96..235f5cde06fc 100644
> --- a/arch/x86/kernel/apic/x2apic_uv_x.c
> +++ b/arch/x86/kernel/apic/x2apic_uv_x.c
> @@ -161,7 +161,7 @@ static int __init early_set_hub_type(void)
>  	/* UV4/4A only have a revision difference */
>  	case UV4_HUB_PART_NUMBER:
>  		uv_min_hub_revision_id = node_id.s.revision
> -					 + UV4_HUB_REVISION_BASE;
> +					 + UV4_HUB_REVISION_BASE - 1;
>  		uv_hub_type_set(UV4);
>  		if (uv_min_hub_revision_id == UV4A_HUB_REVISION_BASE)
>  			uv_hub_type_set(UV4|UV4A);
> -- 
> 2.21.0
> 

-- 
Steve Wahl, Hewlett Packard Enterprise