linux-kernel - Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 19:25:05 +0100
From:   Greg KH <greg@...ah.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Subbu Seetharaman <subbu.seetharaman@...adcom.com>,
        Thomas Lamprecht <t.lamprecht@...xmox.com>,
        James.Bottomley@...e.de,
        jayamohank@...edirect-lb5-1afb6e2973825a56.elb.us-east-1.amazonaws.com,
        jejb@...ux.ibm.com, jitendra.bhivare@...adcom.com,
        kernel-janitors@...r.kernel.org, ketan.mukadam@...adcom.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, stable@...r.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in
 beiscsi_create_eqs()"

On Thu, Dec 03, 2020 at 03:18:26PM +0300, Dan Carpenter wrote:
> My patch caused kernel Oopses and delays in boot.  Revert it.
> 
> The problem was that I moved the "mem->dma = paddr;" before the call to
> be_fill_queue().  But the first thing that the be_fill_queue() function
> does is memset the whole struct to zero which overwrites the assignment.
> 
> Fixes: 38b2db564d9a ("scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()")
> Reported-by: Thomas Lamprecht <t.lamprecht@...xmox.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Can someone please add:
	Cc: stable <stable@...r.kernel.org>
to this so we know to pick it up quickly there?

thanks,

greg k-h