linux-kernel - Re: [PATCH] x86/sgx: Initialize "ret" in sgx_ioc_enclave_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201203182454.GA123023@kapsi.fi>
Date:   Thu, 3 Dec 2020 20:24:54 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@....fi>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Jarkko Sakkinen <jarkko@...nel.org>, x86@...nel.org,
        linux-sgx@...r.kernel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/sgx: Initialize "ret" in sgx_ioc_enclave_add_pages()

On Wed, Dec 02, 2020 at 06:38:29PM +0100, Borislav Petkov wrote:
> On Wed, Dec 02, 2020 at 06:22:00PM +0200, Jarkko Sakkinen wrote:
> > Initialize "ret" to zero as otherwise a zero length address range will
> > leave it uninitialized.
> 
> That length is:
> 
>  * @length:     length of the data (multiple of the page size)
> 
> I think we wanna fail this even earlier when it wants to add data of
> length 0 because that sounds nonsensical to me. Or is there some use
> case for zero-length data?
> 
> Btw, pls CC lkml on patch submissions.

Yeah, makes sense to fail right after copying the parameter struct
with -EINVAL.

> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
> 

/Jarkko